This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Helm: support FHRs that mention more than one image #1180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubeyaml 0.3.2 supports updating the images in a FluxHelmRelease when they are given in the format: ``` somename: image: repo/image:tag othername: image: repo/image:tag ``` This commit bumps the version of kubeyaml in the two places it's mentioned -- the docker file, and the shim script -- and adds a test that it actually does update an FHR given in that format.
We still have largely parallel models of things that are resources in
the cluster, and things that are defined in the git repo. Both models
need to be able to interpret FluxHelmRelease values in terms of
containers.
Because it's the same type (map[string]interface{}) being interpreted
in both places, we can write one procedure to do the interpretation,
and just use the interpretation in different ways. So: factor out a
visitor-style procedure, and use it for cluster and repo resources.
aaron7
approved these changes
Jul 2, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kubeyaml 0.3.2 supports updating the images in a FluxHelmRelease when they are given in the format:
This PR bumps the version of kubeyaml in the two places it's mentioned -- the docker file, and the shim script -- and adds a test that the update code, invoking kubeyaml actually does update an FHR given in that format.
It also adapts kubernetes/resource and kubernetes/ so that the internal model of resources in the repo and in the cluster understand how to interpret FHRs in the same way as kubeyaml does.
Fixes #1175.