This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Fix problem with multiple image support in FluxHelmReleases #1196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When FluxHelmRelease resources are obtained via the Kubernetes API,
maps in the free-form `.spec.values` field are typed
`map[string]interface{}` since it is deserialised from JSON.
So, we have to account for this case as well as the
`map[interface{}]interface{}` that comes from YAML (i.e., manifest
files), if we want to factor the interpretation of `.spec.values` into
a single procedure.
stefanprodan
approved these changes
Jul 4, 2018
|
Thanks Stefan 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1175 didn't quite do the job.
When FluxHelmRelease resources are obtained via the Kubernetes API,
maps in the free-form
.spec.valuesfield are typedmap[string]interface{}since it is deserialised from JSON.So, we have to account for this case as well as the
map[interface{}]interface{}that comes from YAML (i.e., manifestfiles), if we want to factor the interpretation of
.spec.valuesintoa single procedure.