This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Fix ResourceIDRegexp to allow dots in resource names #1199
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some resources (particularly CustomResourceDefinitions) have dots in their names, these are currently considered invalid by ResourceIDRegexp. I do not know if this causes an issue inside of Flux, but I import it for fluxcloud and it breaks unmarshalling events: ``` error decoding: parsing default:customresourcedefinition/clustersecrets.clustersecret.codesink.net: invalid service ID ```
|
Beat you to it, just, in #1197. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some resources (particularly CustomResourceDefinitions) have dots in their names, these
are currently considered invalid by ResourceIDRegexp.
I do not know if this causes an issue inside of Flux, but I import it for fluxcloud and
it breaks unmarshalling events: