This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
git repo improvements for helm operator #1238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the helm operator (and in some places in fluxd) we need only read-only access to the git repo. Indeed in some deployments, the helm operator will be given a read-only SSH key. So: give the git mirroring (git.Repo) a read-only option, which means it will - consider itself ready when it's been cloned, without checking whether it can write to the upstream repo; - not let you make a working clone (because it's assumed you won't be able to push commits from it) We still need a way to get a copy of the repo, so the helm operator can look at the files. For that purpose, add a bare-bones type `git.Export`, with which all you can do is get the directory it's been cloned to.
For fluxd, we have a git mirroring implementation that keeps track of its ready state. This is because when fluxd starts, it may not have a viable SSH key, so it needs to be able to retry in the background, while it does everything else that it can. In the helm operator, and in tests, it's more useful to be able to clone the repo and succeed or fail synchronously. This should remove some flakes from the tests, which previously had to start the repo's loop, and check back with it to see if it was ready -- which would occasionally fail to be the case within the timeout.
Newer gits insist on there being a non-empty path after `--` if it appears. The version of git baked into the container image does not have this quirk, but a newer git on the path may cause tests to fail when run locally.
|
The substance is in https://github.com/weaveworks/flux/pull/1238/files#diff-4e28ed4007c9ceb9cb3efd309643ca04, in which the state machine loop is factored out so it can be used synchronously (in |
|
Thanks Aaron 🍝 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are some improvements to the git mirroring, so that it's usable for the Helm operator.
git.Export, so the helm operator can get at a working tree without all the config baggage that fluxd uses in its working directories