This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Upgrade justinbarrick/go-k8s-portforward to d79fe1b9 #2283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanprodan
approved these changes
Jul 23, 2019
To only look for pods with status.phase=Running while trying to setup a port forward. Given a pod needs to be running to be able to port forward, and to work around scenarios where a node failure ocurred and one pod hangs in a 'terminating' state.
hiddeco
force-pushed
the
enhancement/upgrade-go-k8s-portforward
branch
from
252ac54 to
44a461f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To only look for pods with status.phase=Running while trying to
setup a port forward. Given a pod needs to be running to be able to
port forward, and to work around scenarios where a node failure
occurred and one pod hangs in a 'terminating' state.
Fixes #2276