Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Fix broken doc link #2306

Merged
merged 16 commits into from
Jul 30, 2019
Merged

Fix broken doc link #2306

merged 16 commits into from
Jul 30, 2019

Conversation

rytswd
Copy link
Contributor

@rytswd rytswd commented Jul 29, 2019

After #2152 has been merged, it looks like some of the doc had broken links to other docs due to the path changes. I just scanned all the *.md files that had some directory structure changes in that PR, and updated the entire repo with string replace.
I think I covered most use cases, but please shout if I missed / wrongly replaced any.

@rytswd
Copy link
Contributor Author

rytswd commented Jul 29, 2019

One correction, I did scan other files as well, and thus ended up touching .txt, .tmpl and .go one file each. They are purely for text usage, and I believe they are the correct fix.

As to the build failure, I'm uncertain how this PR can cause any build behaviour change from the previous run. I'm new to the flux repo, and would love if anyone can lend a hand looking into it.

@dholbach dholbach mentioned this pull request Jul 30, 2019
@@ -556,7 +556,7 @@ Commit customization
--git-user
--git-email

See [docs/daemon.md] for more information.
See [docs/features/daemon.md] for more information.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe let's make this a real clickable link?

Copy link
Member

@dholbach dholbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🍍

Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your first contribution @rytswd 🌻

@hiddeco hiddeco merged commit 3f0188f into fluxcd:master Jul 30, 2019
@rytswd rytswd deleted the fix-broken-doc-link branch July 30, 2019 10:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants