This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Fix portforward error check #2394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For traceability reasons, the problem was introduced when vendoring this change oliviabarrick/go-k8s-portforward@649dc88#diff-fd0ea03735acb6add12bf1cca551cdd4R196 and not updating the check consistently. However, the main cause is how shitty error selection is in Golang. |
|
hiddeco
force-pushed
the
fix-portforward-error-check
branch
from
af718e2 to
ada17ad
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were not checking portforwarding errors properly, causing fluxctl to only test the first label selector provided, and in turn causing to fail selecting on
name={"flux", "fluxd", "weave-flux-agent"}as intended byflux/cmd/fluxctl/root_cmd.go
Line 129 in d18267b