This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Fix crash on listing helm releases if v1 release exists #2404
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initialize two variable that weren't initalized before and resulted in a crash when a v1 helm release resource existed in the cluster.
Crash log (before the fix):
This looks like the code will need more tests at some point, but given that the current implementation is completely broken if a v1 helm release exists, this simple fix is probably better than nothing for now.