Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Simplify the files included in kube-config in snapcraft.yaml #2427

Merged
merged 3 commits into from
Sep 10, 2019
Merged

Simplify the files included in kube-config in snapcraft.yaml #2427

merged 3 commits into from
Sep 10, 2019

Conversation

dholbach
Copy link
Member

@dholbach dholbach commented Sep 4, 2019

Simplify the files included in kube-config in snapcraft.yaml
2ca60a6 
	As we can read more files this way, it will make
	fluxctl work in cases where
	   kind clusters have --name set.
@dholbach
Copy link
Member Author

dholbach commented Sep 5, 2019

I pinged Leigh, as this was relevant to some of his work, but can be reviewed by anyone really.

@stealthybox
Copy link
Member

Does this allow recursive access to any kubeconfig file in the ~/.kube directory?
If so, +++++++100

@dholbach
Copy link
Member Author

Thanks for the edit @stealthybox - this is ready to go now. ✔️

hiddeco
hiddeco approved these changes Sep 10, 2019
View reviewed changes
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maintainer stamp of approval 📮

@dholbach dholbach merged commit 060023b into master Sep 10, 2019
@dholbach dholbach deleted the snap-simplify-kubeconfig-files branch September 10, 2019 13:52
@dholbach
Copy link
Member Author

This had to go through the store review process, but is live in edge now:

Track    Arch    Channel    Version          Revision
latest   amd64   stable     1.14.2           30
                 candidate  ^                ^
                 beta       ^                ^
                 edge       1.14.2+bb576fad  35

@hiddeco hiddeco added this to the 1.15.0 milestone Oct 1, 2019
@stealthybox stealthybox mentioned this pull request Oct 16, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stealthybox stealthybox stealthybox left review comments

@hiddeco hiddeco hiddeco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dholbach @stealthybox @hiddeco