This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Use flux namespace in deploy/ examples
#2475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
force-pushed
the
misc/ns-deploy-example
branch
2 times, most recently
from
94a2a95 to
eefe4af
Compare
hiddeco
force-pushed
the
misc/ns-deploy-example
branch
from
eefe4af to
dac09a5
Compare
This is so that the configuration is not effected by e.g. a namespace context set in the `kubectl` config of the user, as this caused problems during the creation of the `ClusterRoleBinding` which was set to the `default` namespace, while the resources themselves would be created in the user their configured namespace. It also simplifies the 'Get started with Kustomize' guide, as a user does no longer need to create the namespace as a prerequisite but is still able to overwrite it by adding a `namespace: <targetNamespace>` to their `kustomization.yaml`.
hiddeco
force-pushed
the
misc/ns-deploy-example
branch
from
dac09a5 to
bdb197e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is so that the configuration is not effected by e.g. a namespace
context set in the
kubectlconfig of the user, as this causedproblems during the creation of the
ClusterRoleBindingwhich was setto the
defaultnamespace, while the resources themselves would becreated in the user their configured namespace.
It also simplifies the 'Get started with Kustomize' guide, as a user
does no longer need to create the namespace as a prerequisite but is
still able to overwrite it by adding a
namespace: <targetNamespace>to their
kustomization.yaml.Supersedes #2454