Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Build: release modifications #2491

Merged
merged 2 commits into from
Oct 2, 2019
Merged

Build: release modifications #2491

merged 2 commits into from
Oct 2, 2019

Conversation

hiddeco
Copy link
Member

@hiddeco hiddeco commented Oct 2, 2019 •
edited
Loading

  • Stop publishing images to Weaveworks DockerHub
  • Republish release tag with a v prefix, to make the release available to Go Mod

@hiddeco hiddeco added the build About the build or test scaffolding label Oct 2, 2019
@hiddeco hiddeco changed the title Stop publishing images to Weaveworks DockerHub Build: release modifications Oct 2, 2019
stefanprodan
stefanprodan approved these changes Oct 2, 2019
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After this we have to review the brew formula, I think the fluxctl download URLs will stop working.

@hiddeco
Copy link
Member Author

hiddeco commented Oct 2, 2019

I think the fluxctl download URLs will stop working.

I think they will continue to work as long as we continue publishing our releases on GitHub without the v added to the tag. The CI will take care of adding an additional Go Mod-compliant tag, and all other script / formula things that depend on the non-v tag won't notice a thing.

@hiddeco hiddeco force-pushed the build/del-weaveworks-image-push branch 2 times, most recently from cf7a075 to 8d5936b Compare October 2, 2019 10:31
@hiddeco hiddeco force-pushed the build/del-weaveworks-image-push branch from 8d5936b to a68299b Compare October 2, 2019 10:44
@hiddeco hiddeco merged commit 4748d2d into master Oct 2, 2019
@hiddeco hiddeco deleted the build/del-weaveworks-image-push branch October 2, 2019 10:56
@stefanprodan stefanprodan mentioned this pull request Oct 9, 2019
Closed
@2opremio 2opremio added this to the 1.16.0 milestone Nov 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stefanprodan stefanprodan stefanprodan approved these changes

@squaremo squaremo Awaiting requested review from squaremo

Assignees
No one assigned
Labels
build About the build or test scaffolding
Projects
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.
3 participants
@hiddeco @stefanprodan @2opremio