Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Change snap confinement to classic #2529

Merged
merged 3 commits into from
Dec 12, 2019
Merged

Change snap confinement to classic #2529

merged 3 commits into from
Dec 12, 2019

Conversation

dholbach
Copy link
Member

@dholbach dholbach commented Oct 18, 2019

@dholbach dholbach self-assigned this Oct 18, 2019
@dholbach dholbach force-pushed the change-snap-to-classic branch from e531dcd to 24702e4 Compare October 18, 2019 15:32
@dholbach dholbach changed the title Change snap conrinement to classic Change snap confinement to classic Oct 18, 2019
@2opremio
Copy link
Contributor

2opremio commented Nov 8, 2019

@dholbach is this PR still relevant?

@dholbach
Copy link
Member Author

dholbach commented Nov 8, 2019

Yes. Things are still sort of being discussed in snap land.

@dholbach dholbach marked this pull request as ready for review December 10, 2019 10:38
@dholbach
Copy link
Member Author

According to https://forum.snapcraft.io/t/classic-confinement-for-fluxctl/13816/5 we can now use classic confinement.

Copy link
Contributor

@2opremio 2opremio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (caveat: I don't know enough about snap to judge whether the confinement change could be problematic)

@dholbach dholbach force-pushed the change-snap-to-classic branch from 30dcc89 to 6a83bfe Compare December 12, 2019 12:42
@dholbach dholbach merged commit a959049 into master Dec 12, 2019
@dholbach dholbach deleted the change-snap-to-classic branch December 12, 2019 13:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fluxctl snap cannot exec auth helpers (ex: aws-iam-authenticator)
2 participants