Add 'fluxctl install' e2e smoke test #2552
Conversation
| kubectl -n "${FLUX_NAMESPACE}" rollout status deployment/flux | ||
| # Add the known hosts file manually (it's much easier than editing the manifests to add a volume) | ||
| local flux_podname=$(kubectl get pod -n flux-e2e -l name=flux -o jsonpath="{['items'][0].metadata.name}") | ||
| kubectl exec -n "${FLUX_NAMESPACE}" "${flux_podname}" -- sh -c "echo '$(cat ${FIXTURES_DIR}/known_hosts)' > /root/.ssh/known_hosts" |
There was a problem hiding this comment.
This is pretty horrible. I'm open for suggestions.
There was a problem hiding this comment.
this comment is also aimed at the sed expressions above (I tried to make a comment on the full block of code but it seems I failed)
There was a problem hiding this comment.
Doesn't the install package already support additionalArguments? What about instead of doing the sed, we make a small adjustment to fluxctl install to accept a string slice of additional arguments, and then utilize this here?
There actually was someone on Slack yesterday who was wondering how he could use his own image with fluxctl install. So maybe adding an option to supply an own image to fluxctl install wouldn't even be a bad idea.
There was a problem hiding this comment.
I like your suggestions. I initially incorporated --extra-flux-arguments, but @squaremo thought it was better to edit the output. See #2287 (review)
@squaremo I still think there is a valid usecase here, could you reevaluate?
There was a problem hiding this comment.
@hiddeco regardless, I will fix this in a separate PR. Are you OK with the rest?
There was a problem hiding this comment.
Is it possible to run the output of fluxctl install through kustomize to do the patching you need?
2opremio
force-pushed
the
improve-e2e-test
branch
from
e9806d7 to
c14cb77
Compare
2opremio
force-pushed
the
improve-e2e-test
branch
from
d16e3cb to
005ba5c
Compare
Also: