Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Delete old integration tests #2575

Merged
merged 3 commits into from
Nov 4, 2019

Conversation

2opremio
Copy link
Contributor

@2opremio 2opremio commented Nov 4, 2019

No description provided.

@2opremio 2opremio requested a review from hiddeco November 4, 2019 14:52
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗑️ 🎉

@hiddeco
Copy link
Member

hiddeco commented Nov 4, 2019

@2opremio you need to add a .gitkeep in the test/bin directory, the tests are now failing because the target dir doesn't exist.

cp: cannot create regular file 'test/bin/helm': No such file or directory

Makefile:104: recipe for target 'test/bin/helm' failed

make: *** [test/bin/helm] Error 1

I also added a rule to a .gitignore file which ignores the test/bin/ directory, but had an exception for the test-flux script (!test/bin/test-flux), this should now be removed.

@2opremio
Copy link
Contributor Author

2opremio commented Nov 4, 2019

Ah, I will add an mkdir -p in the installation recipes

@2opremio 2opremio merged commit 703bd57 into fluxcd:master Nov 4, 2019
@2opremio 2opremio added this to the 1.16.0 milestone Nov 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants