This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
e2e: Misc fixes and refactorings #2587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, declare variables as local when necessary
2opremio
force-pushed
the
e2e-refactor
branch
from
89690ed to
5015abc
Compare
2opremio
force-pushed
the
e2e-refactor
branch
5 times, most recently
from
1e31c7f to
cf9fba5
Compare
Also, remove parameterization of secret names (in order to simplify things). We always used the same secret names anyways.
2opremio
force-pushed
the
e2e-refactor
branch
2 times, most recently
from
2aade7a to
06fee0c
Compare
2opremio
force-pushed
the
e2e-refactor
branch
from
06fee0c to
a5e8f43
Compare
2opremio
force-pushed
the
e2e-refactor
branch
from
ffb4260 to
ffd898f
Compare
hiddeco
reviewed
Nov 8, 2019
2opremio
commented
Nov 8, 2019
hiddeco
reviewed
Nov 8, 2019
hiddeco
approved these changes
Nov 8, 2019
Also, make sure we call uninstall_flux_with_fluxctl in the garbage collection test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.