This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Exclude the metrics APIs from resources discovery #2606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @stefanprodan ! It looks good, however I am not sure whether the specific discovery functions you are calling are cached (I vaguely recall that the memory-cache implementation of the discovery interface only applied caching to certain functions, and that's partly why I chose |
|
It uses the same client as before https://github.com/kubernetes/client-go/blob/master/discovery/discovery_client.go When enabling the go client logging the caller is: |
squaremo
reviewed
Nov 13, 2019
squaremo
reviewed
Nov 13, 2019
stefanprodan
force-pushed
the
no-metrics-dicovery
branch
from
1f7340f to
db7d04d
Compare
squaremo
reviewed
Nov 13, 2019
stefanprodan
force-pushed
the
no-metrics-dicovery
branch
from
db7d04d to
ecd12bf
Compare
|
@squaremo anything else blocking this? I've rebase with master. |
squaremo
reviewed
Nov 13, 2019
squaremo
approved these changes
Nov 13, 2019
stefanprodan
force-pushed
the
no-metrics-dicovery
branch
from
ecd12bf to
dc8c1b9
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the Kubernetes resources discovery to exclude the
*.metrics.k8s.ioAPI groups and thus avoiding querying the cluster metrics and failing to sync when the metrics providers are unavailable.Tested on EKS with metrics server and by @texasbobs with Prometheus adapter.
Fix: #2605
Fix: #2120
Fix: #2192