This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Support unwrapping NotReadyError
#2617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This error is heavily used by the Helm operator to determine if it can proceed with a release making use of a git source. It is however not so easy to only get the reason of failure from the error in it's existing form, and add our own Helm operator related context to it, without repeating ourselves. This commit adds the in Golang 1.13 introduced `Unwrap` method to the error, so that the underlying error can be unwrapped from the returned error on e.g. `Status()` calls. https://blog.golang.org/go1.13-errors
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This error is heavily used by the Helm operator to determine if it
can proceed with a release making use of a git source. It is however
not so easy to only get the reason of failure from the error in it's
existing form, and add our own Helm operator related context to it,
without repeating ourselves.
This commit adds the in Golang 1.13 introduced
Unwrapmethod to theerror, so that the underlying error can be unwrapped from the returned
error on e.g.
Status()calls.https://blog.golang.org/go1.13-errors