This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Parse image refs in HelmReleases with >2 elements #2620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
force-pushed
the
bug/hr-multi-element-img
branch
2 times, most recently
from
6d3faa8 to
28de73c
Compare
|
/review-roulette |
This commit fixes the parsing of image references with more than 2 elements in `HelmRelease` resources. The previous version made the assumption that any given image value given to `image.ParseRef()` would result in a `image.Ref` with only the image name set. This assumption is however wrong as the parser will set the first element of the passed string split by `/` to be the domain in case there are more than 2 elements in total, resulting in the first element to be overwritten by a new domain value, if detected at a later stage. The solution is to construct the full image ref before calling `image.ParseRef()`, preventing a partial parse of any image element snippets that may result in a misinterpretation of the image reference.
hiddeco
force-pushed
the
bug/hr-multi-element-img
branch
from
28de73c to
d25a4a9
Compare
squaremo
approved these changes
Nov 19, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the parsing of image references with more than
2 elements in
HelmReleaseresources.The previous version made the assumption that any given image value
given to
image.ParseRef()would result in aimage.Refwith onlythe image name set. This assumption is however wrong as the parser
will set the first element of the passed string split by
/to bethe domain in case there are more than 2 elements in total, resulting
in the first element to be overwritten by a new domain value, if
detected at a later stage.
The solution is to construct the full image ref before calling
image.ParseRef(), preventing a partial parse of any image elementsnippets that may result in a misinterpretation of the image reference.
Fixes #2618