Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Upgrading to latest memcached image which uses debian buster #2637

Merged
merged 1 commit into from
Dec 3, 2019

Conversation

adusumillipraveen
Copy link
Contributor

Moving to latest image as debian stretch has vulnerabilities( which our CSP keeps warning us about ) and also because it has other advantages.

chart/flux/Chart.yaml Outdated Show resolved Hide resolved
@2opremio
Copy link
Contributor

2opremio commented Nov 27, 2019

I think it may be better to drop the patch version number and simply use 1.5. Mutable tags are an anti-pattern, but ensuring implicit patch upgrades through semver is probably worth it (we already do it, intentionally or not, when building our Alpine-based Flux image).

@squaremo thoughts?

@squaremo
Copy link
Member

squaremo commented Dec 3, 2019

I think it may be better to drop the patch version number and simply use 1.5

You can certainly do that for a particular installation; that's an easier decision to endorse than making it so for everyone.

@2opremio
Copy link
Contributor

2opremio commented Dec 3, 2019

Actually, after thinking about it further, it's not like we do when building Flux. The base image used by Flux is immutable but it's always the same when deploying (so, you cannot end up with different images when re-deploying, for instance).

Copy link
Contributor

@2opremio 2opremio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (after reverting the chart change)

@2opremio 2opremio merged commit 7e148c2 into fluxcd:master Dec 3, 2019
@2opremio
Copy link
Contributor

2opremio commented Dec 4, 2019

I had to regenerate pkg/install/generated_templates.gogen.go and push it to master directly (see d16d92e) because this missed it.

It should had been automatically detected by CI, but make check-generated didn't work in the latest build of this PR (https://circleci.com/gh/fluxcd/flux/8813 ) nor in the merge build in master ( https://circleci.com/gh/fluxcd/flux/8819 )

I noticed when working on a later, unrelated PR (#2626 ) for which make check-generated did work ( https://circleci.com/gh/fluxcd/flux/8826 ). Why that happen is beyond me at this point.

@2opremio 2opremio added this to the 1.17.0 milestone Dec 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants