This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Pseudo randomize push check tag #2684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is the e2e failure legitimate? It's hard to tell from the logs :S |
2opremio
reviewed
Dec 11, 2019
When multiple Flux instances are synchronizing with the same repository but different branches, and the upstream has some latency, they get confused about the write check they are performing due to the tag being overwritten with a commit hash that does not belong to the branch they are synchronzing with. This commit pseudo randomizes the tag used to check if we can write to the upstream repository and removes the `--force` options from the tag and push commands so that the tag is never accidentally overwritten and multiple instances no longer get in each other's way.
hiddeco
force-pushed
the
bug/pseudo-rand-push-tag
branch
from
0ca0e96 to
c5158c1
Compare
2opremio
approved these changes
Dec 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multiple Flux instances are synchronizing with the same repository
but different branches, and the upstream has some latency, they get
confused about the write check they are performing due to the tag
being overwritten with a commit hash that does not belong to the branch
they are synchronzing with.
This commit pseudo randomizes the tag used to check if we can write to
the upstream repository and removes the
--forceoptions from the tagand push commands so that the tag is never accidentally overwritten and
multiple instances no longer get in each other's way.
Fixes #2683