Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Add context option to fluxctl #2715

Merged
merged 1 commit into from
Jan 9, 2020
Merged

Add context option to fluxctl #2715

merged 1 commit into from
Jan 9, 2020

Conversation

roffe
Copy link
Contributor

@roffe roffe commented Dec 28, 2019

I'm building some shell scripts for our developers that includes fluxctl and since we have multiple contexts in our kubectl config this option is a must for some of our usage cases where id like to run fluxctl against different clusters

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @roffe

@stefanprodan stefanprodan changed the title Context option Add context option to fluxctl Dec 28, 2019
@stefanprodan stefanprodan added this to the 1.18.0 milestone Dec 28, 2019
cmd/fluxctl/root_cmd.go Outdated Show resolved Hide resolved
docs/references/fluxctl.md Outdated Show resolved Hide resolved
@roffe
Copy link
Contributor Author

roffe commented Jan 9, 2020

just get the ball rolling. potatoe or potata, the options are already cluttered

@2opremio
Copy link
Contributor

2opremio commented Jan 9, 2020

Just leave at --context (since it seems to be the most intuitive for users), sorry for making you change it.

@2opremio
Copy link
Contributor

2opremio commented Jan 9, 2020

Can you squash your commits and rebase on master? Otherwise it LGTM

@roffe
Copy link
Contributor Author

roffe commented Jan 9, 2020

@2opremio should be ok now

cmd/fluxctl/args.go Outdated Show resolved Hide resolved
cmd/fluxctl/args.go Outdated Show resolved Hide resolved
@2opremio
Copy link
Contributor

2opremio commented Jan 9, 2020

I missed a couple of kubectl references. Happy to merge after that

@2opremio 2opremio merged commit 997d1da into fluxcd:master Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants