This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanprodan
approved these changes
Dec 28, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @roffe
2opremio
reviewed
Jan 8, 2020
2opremio
reviewed
Jan 8, 2020
2opremio
reviewed
Jan 8, 2020
just get the ball rolling. potatoe or potata, the options are already cluttered |
Just leave at |
Can you squash your commits and rebase on master? Otherwise it LGTM |
@2opremio should be ok now |
2opremio
reviewed
Jan 9, 2020
2opremio
reviewed
Jan 9, 2020
I missed a couple of |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm building some shell scripts for our developers that includes fluxctl and since we have multiple contexts in our kubectl config this option is a must for some of our usage cases where id like to run fluxctl against different clusters