This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Make docker/image-tag work with multiple version tags #2748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that the release process for, say 1.19.1 adds an extra tag v1.19.1, that made docker/image-tag simply print both tags. Also, I removed code related to the Helm Operator.
|
@2opremio have you consider this https://github.com/fluxcd/helm-operator/blob/master/docker/image-tag#L16 |
|
That code silently succeeds if two tags point to HEAD, I think the code in this PR is more robust (although it doesn't validate that the tags are semvers) |
|
Is it OK to merge then? CC @hiddeco |
hiddeco
approved these changes
Jan 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that the release process for, say 1.19.1
adds an extra tag v1.19.1, that made docker/image-tag
simply print both tags.
Also, I removed code related to the Helm Operator.