This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Fix conditional statement determining in-cluster setup #2760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
force-pushed
the
bug/incluster-check
branch
from
6428ca4 to
02c2ec6
Compare
2opremio
reviewed
Jan 17, 2020
| @test "SSH key is generated" { | ||
| run fluxctl identity --k8s-fwd-ns "$FLUX_NAMESPACE" | ||
| [ "$status" -eq 0 ] | ||
| [ "$output" != "" ] |
There was a problem hiding this comment.
I think we can do a bit better than this. Could you parse the output and check it's a valid public key?
There was a problem hiding this comment.
Also, we may want to do polling, since the key may not be ready right after flux is deployed.
There was a problem hiding this comment.
The key is now validated in two ways:
- it is parsed by
ssh-keygento compute the fingerprint, which will fail for an invalid key - the fingerprint is compared to the output of
fluxctl identity -l
2opremio
reviewed
Jan 17, 2020
test/e2e/fixtures/kustom/21_ssh_key_generation/generation_patch.yaml
Outdated
Show resolved
Hide resolved
|
Addresses part of #2593 |
hiddeco
force-pushed
the
bug/incluster-check
branch
from
02c2ec6 to
23dfff7
Compare
2opremio
approved these changes
Jan 17, 2020
hiddeco
force-pushed
the
bug/incluster-check
branch
from
23dfff7 to
0aa284d
Compare
hiddeco
force-pushed
the
bug/incluster-check
branch
from
0aa284d to
e53db89
Compare
hiddeco
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #2741