This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Delete headers for list-images and list-workloads #2767
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2opremio
reviewed
Jan 21, 2020
2opremio
approved these changes
Jan 21, 2020
Please rebase on master instead of merging master in |
Also, please update the |
ogerbron
force-pushed
the
Delete-headers
branch
from
January 27, 2020 15:27
f702a16
to
58dc171
Compare
2opremio
reviewed
Jan 27, 2020
docs/references/fluxctl.md
Outdated
@@ -290,6 +290,19 @@ default:deployment/helloworld helloworld quay.io/weaveworks/helloworld | |||
The arrows will point to the version that is currently running | |||
alongside a list of other versions and their timestamps. | |||
|
|||
For those using `fluxctl` in scripts, have a look at `--no-headers` for both `list-images` and `list-workloads` command to suppress the header: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
For those using `fluxctl` in scripts, have a look at `--no-headers` for both `list-images` and `list-workloads` command to suppress the header: | |
When using `fluxctl` in scripts, you can remove the table headers with `--no-headers` for both `list-images` and `list-workloads` command to suppress the header: |
2opremio
reviewed
Jan 27, 2020
2opremio
reviewed
Jan 27, 2020
2opremio
reviewed
Jan 27, 2020
ogerbron
force-pushed
the
Delete-headers
branch
from
January 28, 2020 07:41
903896f
to
c67354a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an optional argument to fluxctl
list-images
andlist-workloads
. It gives the ability to delete the list header. This is especially useful when using fluxctl in shell scripts.For example:
I am quite new to Go programming, so do not hesitate to correct me or give me hints on how I can be a better contributor :).