Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Delete headers for list-images and list-workloads #2767

Merged
merged 3 commits into from
Jan 28, 2020

Conversation

ogerbron
Copy link
Contributor

This PR adds an optional argument to fluxctl list-images and list-workloads. It gives the ability to delete the list header. This is especially useful when using fluxctl in shell scripts.

For example:

$> fluxctl list-workloads --no-headers
default:deployment/micro-service-process-1   my-container  docker/my-container:master  ready    automated
default:deployment/micro-service-process-2   my-container  docker/my-container:master  ready    automated
default:deployment/micro-service-process-3   my-container  docker/my-container:master  ready    automated

I am quite new to Go programming, so do not hesitate to correct me or give me hints on how I can be a better contributor :).

@2opremio
Copy link
Contributor

2opremio commented Jan 27, 2020

Please rebase on master instead of merging master in

@2opremio
Copy link
Contributor

Also, please update the fluxctl documentation and make sure that CI succeeds.

@@ -290,6 +290,19 @@ default:deployment/helloworld helloworld quay.io/weaveworks/helloworld
The arrows will point to the version that is currently running
alongside a list of other versions and their timestamps.

For those using `fluxctl` in scripts, have a look at `--no-headers` for both `list-images` and `list-workloads` command to suppress the header:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For those using `fluxctl` in scripts, have a look at `--no-headers` for both `list-images` and `list-workloads` command to suppress the header:
When using `fluxctl` in scripts, you can remove the table headers with `--no-headers` for both `list-images` and `list-workloads` command to suppress the header:

@2opremio 2opremio merged commit fd6e2da into fluxcd:master Jan 28, 2020
@2opremio 2opremio added this to the 1.18.0 milestone Jan 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants