This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Maintain pkg/install as a separate module with own deps
#2777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2opremio
reviewed
Jan 21, 2020
| @@ -19,6 +19,9 @@ replace ( | |||
| k8s.io/client-go => k8s.io/client-go v0.0.0-20191016111102-bec269661e48 // kubernetes-1.16.2 | |||
| ) | |||
|
|
|||
| // ugh | |||
There was a problem hiding this comment.
I actually think it's pretty nifty, it saves you from bumping the dependency on every release.
There was a problem hiding this comment.
It is, this was my brain still being traumatized by the
github.com/fluxcd/flux/cmd/fluxctl imports
github.com/fluxcd/flux/pkg/install: no matching versions for query "latest"message that popped up.
I am wondering however what the impact is when someone (weirdly) decides they want to depend on different pkg/install and flux module versions, or are local path overwrites ignored while depending on something?
|
#2778 also removes the import in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.