Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

fix(charts): Added missing flag #2870

Merged
merged 3 commits into from
Feb 25, 2020
Merged

fix(charts): Added missing flag #2870

merged 3 commits into from
Feb 25, 2020

Conversation

nij4t
Copy link
Contributor

@nij4t nij4t commented Feb 22, 2020

Closes #2869
Related to #2159

@hiddeco
Copy link
Member

hiddeco commented Feb 24, 2020

Small and friendly note that requesting additional reviewers during the weekend has little effect as we officially only work during weekdays. As a matter of fact, we actively monitor incoming PRs, even without requesting reviews. 🌻

@nij4t nij4t requested review from hiddeco and removed request for stefanprodan February 24, 2020 14:33
@hiddeco
Copy link
Member

hiddeco commented Feb 24, 2020

Did you forget to include some of your commits? I only observe the removal of the version bump in the Chart.yaml, but not any of the other suggested changes.

@hiddeco hiddeco merged commit 4bbf781 into fluxcd:master Feb 25, 2020
@hiddeco
Copy link
Member

hiddeco commented Feb 25, 2020

Thank you @nij4t 🌷🥇

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chart does not handle git-secret
2 participants