Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

docs: nitpicks #2941

Merged
merged 2 commits into from
Mar 27, 2020
Merged

docs: nitpicks #2941

merged 2 commits into from
Mar 27, 2020

Conversation

hiddeco
Copy link
Member

@hiddeco hiddeco commented Mar 27, 2020

Nitpick follow up on #2919.

@hiddeco hiddeco added the docs Issue or PR relates to documentation label Mar 27, 2020
@hiddeco hiddeco requested a review from dholbach March 27, 2020 11:05
stefanprodan
stefanprodan suggested changes Mar 27, 2020
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please run make generate-deploy

dholbach
dholbach approved these changes Mar 27, 2020
View reviewed changes
Copy link
Member

@dholbach dholbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nicely done! 💯

@dholbach dholbach requested a review from stefanprodan March 27, 2020 11:29
@hiddeco
Copy link
Member Author

hiddeco commented Mar 27, 2020

@dholbach make generate-deploy is taken care of in #2942, I will rebase as soon as that's merged (which should erase your commit).

@dholbach
Copy link
Member

dholbach commented Mar 27, 2020 •
edited
Loading

sorry for the mid-air collision

@hiddeco
Copy link
Member Author

hiddeco commented Mar 27, 2020

Formation restored.

hiddeco added 2 commits March 27, 2020 12:53
@hiddeco
docs: make index look more like an actual page
5b0fd32 
By removing the (duplicated) menu and copying some sections from
the `README.md` in.
@hiddeco
docs: 'Helm operator' -> 'Helm Operator'
cf0bcad
stefanprodan
stefanprodan approved these changes Mar 27, 2020
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@hiddeco hiddeco merged commit 54dc2f4 into master Mar 27, 2020
@hiddeco hiddeco deleted the docs/nitpicks branch March 27, 2020 12:11
@dholbach dholbach added this to the 1.19.0 milestone Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stefanprodan stefanprodan stefanprodan approved these changes

@dholbach dholbach dholbach approved these changes

Assignees
No one assigned
Labels
docs Issue or PR relates to documentation
Projects
None yet
Milestone
1.19.0
Development

Successfully merging this pull request may close these issues.
3 participants
@hiddeco @dholbach @stefanprodan