Merge pull request #52 from kisoku/kubeconform

Replace kubeval with kubeconform for static analysis

.github/actions/tools/entrypoint.sh

@@ -4,27 +4,25 @@ set -eu
 
 YQ_VERSION="v4.6.1"
 KUSTOMIZE_VERSION="4.5.2"
-KUBEVAL_VERSION="0.15.0"
+KUBECONFORM_VERSION="0.4.12"
 
 mkdir -p $GITHUB_WORKSPACE/bin
+cd $GITHUB_WORKSPACE/bin
 
 curl -sL https://github.com/mikefarah/yq/releases/download/${YQ_VERSION}/yq_linux_amd64 -o yq
 
-cp ./yq $GITHUB_WORKSPACE/bin
 chmod +x $GITHUB_WORKSPACE/bin/yq
 
 kustomize_url=https://github.com/kubernetes-sigs/kustomize/releases/download && \
 curl -sL ${kustomize_url}/kustomize%2Fv${KUSTOMIZE_VERSION}/kustomize_v${KUSTOMIZE_VERSION}_linux_amd64.tar.gz | \
 tar xz
 
-cp ./kustomize $GITHUB_WORKSPACE/bin
 chmod +x $GITHUB_WORKSPACE/bin/kustomize
 
-curl -sL https://github.com/instrumenta/kubeval/releases/download/${KUBEVAL_VERSION}/kubeval-linux-amd64.tar.gz | \
+curl -sL https://github.com/yannh/kubeconform/releases/download/v${KUBECONFORM_VERSION}/kubeconform-linux-amd64.tar.gz | \
 tar xz
 
-cp ./kubeval $GITHUB_WORKSPACE/bin
-chmod +x $GITHUB_WORKSPACE/bin/kubeval
+chmod +x $GITHUB_WORKSPACE/bin/kubeconform
 
 echo "$GITHUB_WORKSPACE/bin" >> $GITHUB_PATH
 echo "$RUNNER_WORKSPACE/$(basename $GITHUB_REPOSITORY)/bin" >> $GITHUB_PATH

README.md

@@ -526,5 +526,5 @@ a pull requests is merged into the main branch and synced on the cluster.
 
 This repository contains the following GitHub CI workflows:
 
-* the [test](./.github/workflows/test.yaml) workflow validates the Kubernetes manifests and Kustomize overlays with kubeval
+* the [test](./.github/workflows/test.yaml) workflow validates the Kubernetes manifests and Kustomize overlays with [kubeconform](https://github.com/yannh/kubeconform)
 * the [e2e](./.github/workflows/e2e.yaml) workflow starts a Kubernetes cluster in CI and tests the staging setup by running Flux in Kubernetes Kind

scripts/validate.sh

@@ -25,8 +25,8 @@
 
 # Prerequisites
 # - yq v4.6
-# - kustomize v4.5
-# - kubeval v0.15
+# - kustomize v4.1
+# - kubeconform v0.4.12
 
 set -o errexit
 
@@ -40,10 +40,12 @@ find . -type f -name '*.yaml' -print0 | while IFS= read -r -d $'\0' file;
     yq e 'true' "$file" > /dev/null
 done
 
+kubeconform_config="-strict -ignore-missing-schemas -schema-location default -schema-location /tmp/flux-crd-schemas -verbose"
+
 echo "INFO - Validating clusters"
 find ./clusters -maxdepth 2 -type f -name '*.yaml' -print0 | while IFS= read -r -d $'\0' file;
   do
-    kubeval ${file} --strict --ignore-missing-schemas --additional-schema-locations=file:///tmp/flux-crd-schemas
+    kubeconform $kubeconform_config ${file}
     if [[ ${PIPESTATUS[0]} != 0 ]]; then
       exit 1
     fi
@@ -58,7 +60,7 @@ find . -type f -name $kustomize_config -print0 | while IFS= read -r -d $'\0' fil
   do
     echo "INFO - Validating kustomization ${file/%$kustomize_config}"
     kustomize build "${file/%$kustomize_config}" $kustomize_flags | \
-      kubeval --ignore-missing-schemas --strict --additional-schema-locations=file:///tmp/flux-crd-schemas
+      kubeconform $kubeconform_config
     if [[ ${PIPESTATUS[0]} != 0 ]]; then
       exit 1
     fi