bootstrap: Set ECDSA as the default SSH key algorithm #2041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: RSA SHA-1 SSH keys are no longer accepted by GitHub https://github.blog/2021-09-01-improving-git-protocol-security-github/. Given this we are switching the default from RSA to ECDSA for `git`, `github` and `gitlab` variants of `flux bootstrap`. Signed-off-by: Stefan Prodan <[email protected]>
hiddeco
approved these changes
Nov 2, 2021
|
NB: switching to the RSA-SHA2 alternative is not possible, as Go lacks support for this format. |
Signed-off-by: Stefan Prodan <[email protected]>
|
@stefanprodan Just curious, why ECDSA? github seems to recommend ed25519, others do as well? |
|
ECDSA has trust issues all over, Ed25519 could have been a better choice here. RSA keys aren't going away, just usage of SHA-1 signatures during authentication, which affects older clients. However as @hiddeco mentioned, looks like golang doesn't handle it yet, even though it's been part of OpenSSH for a while. golang/go#37278 |
|
Due to various parts of Flux depending on |
makkes
pushed a commit
to fluxcd/website
that referenced
this pull request
Mar 24, 2023
We changed the default algorithm to ECDSA in fluxcd/flux2#2041. Signed-off-by: Max Jonas Werner <[email protected]>
makkes
pushed a commit
to fluxcd/website
that referenced
this pull request
Mar 24, 2023
We changed the default algorithm to ECDSA in fluxcd/flux2#2041. Signed-off-by: Max Jonas Werner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: RSA SHA-1 SSH keys are no longer accepted by GitHub https://github.blog/2021-09-01-improving-git-protocol-security-github/.
Given this we are switching the default from RSA to ECDSA for
git,githubandgitlabvariants offlux bootstrap.Fix: #2040