Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to diff with a local Flux Kustomization file #2611

Merged
merged 1 commit into from
Apr 5, 2022

Conversation

souleb
Copy link
Member

@souleb souleb commented Apr 4, 2022

If implemented, users will be able to provide a local Flux Kustomization YAML file to flux build/diff.

Signed-off-by: Soule BA [email protected]

@souleb souleb added the area/diff Diff related issues and pull requests label Apr 4, 2022
@souleb souleb force-pushed the diff-local-kustomization branch from 457c519 to e1593cb Compare April 5, 2022 13:21
@souleb souleb force-pushed the diff-local-kustomization branch from e1593cb to d75ea7e Compare April 5, 2022 14:36
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @souleb 🏅

If implemented, users will be able to provide a local kustomization file
to `flux build/diff`.

Signed-off-by: Soule BA <[email protected]>
@souleb souleb force-pushed the diff-local-kustomization branch from d75ea7e to 5536af9 Compare April 5, 2022 15:21
@stefanprodan stefanprodan changed the title Add an option to diff with a local kustomization file Add an option to diff with a local Flux Kustomization file Apr 5, 2022
@stefanprodan stefanprodan added enhancement New feature or request area/UX labels Apr 5, 2022
@stefanprodan stefanprodan merged commit cb53243 into fluxcd:main Apr 5, 2022
@stefanprodan stefanprodan deleted the diff-local-kustomization branch April 5, 2022 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/diff Diff related issues and pull requests enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants