Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify tmp dir generation to be absolute on all OSes #2703

Merged
merged 1 commit into from
May 4, 2022

Conversation

aryan9600
Copy link
Member

Fixes: #2699

Signed-off-by: Sanskar Jaiswal [email protected]

@aryan9600 aryan9600 requested review from hiddeco and stefanprodan May 4, 2022 09:20
pkg/manifestgen/tmpdir.go Outdated Show resolved Hide resolved
@hiddeco hiddeco added bug Something isn't working area/bootstrap Bootstrap related issues and pull requests labels May 4, 2022
@aryan9600 aryan9600 force-pushed the fix-securefs-macos branch from ac3a434 to cd479c9 Compare May 4, 2022 09:42
@aryan9600 aryan9600 force-pushed the fix-securefs-macos branch from cd479c9 to 7232ff9 Compare May 4, 2022 09:43
if err != nil {
return err
}
if err = fs.WriteFile(output, resources); err != nil {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are many places where we do this with os.WriteFile. Maybe we should do a followup PR and use our SecureFS everywhere.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather like to introduce our own https://pkg.go.dev/io/fs implementation which is consistently used, than to further build on Kustomize's FS interface.

@hiddeco hiddeco merged commit e09078f into fluxcd:main May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/bootstrap Bootstrap related issues and pull requests bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cannot upgrade to 0.30.0 on macOS
3 participants