Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error message in get cmd #3019

Merged
merged 1 commit into from
Aug 24, 2022
Merged

Improve error message in get cmd #3019

merged 1 commit into from
Aug 24, 2022

Conversation

somtochiama
Copy link
Member

@somtochiama somtochiama commented Aug 22, 2022 •
edited
Loading

Before

➜  flux get ks me
✗ no Kustomization objects found in flux-system namespace # misleading as there are Kustomizations in the flux-system namespace

Now:

➜  ./bin/flux get ks me
✗ Kustomization object 'me' not found in `flux-system` namespace

Signed-off-by: Somtochi Onyekwere [email protected]

hiddeco
hiddeco reviewed Aug 23, 2022
View reviewed changes
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it still be worth taking note of the namespace for a single object in the error message?

@somtochiama
Improve error message in get cmd
ad0f337 
Signed-off-by: Somtochi Onyekwere <[email protected]>
@stefanprodan stefanprodan merged commit 9f26b09 into fluxcd:main Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiddeco hiddeco hiddeco left review comments

@stefanprodan stefanprodan stefanprodan approved these changes

@makkes makkes makkes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@somtochiama @makkes @stefanprodan @hiddeco