Create secret with bearer-token

[Santosh1176]

This is for creating a secret with a git bearer-token.
The tests are failing due to some new lines being added to the golden file. I've tested the generated manifest and it's in line with the one in the ./testdata dir.

I need further guidance on whether the data for bearerToken needs to be captured as .data.bearerToken or .stringData.bearerToken? The current implementation is for .stringData

This PR attempts to close #3536

[Santosh1176]

@aryan9600 Thank you for the review. I've addressed them as advised, requesting a review.

[darkowlzz]

The tests are failing due to some new lines being added to the golden file. I've tested the generated manifest and it's in line with the one in the ./testdata dir.

@Santosh1176 I tried your tests and found that the newline is expected. Our test tooling supports an -update flag that can be used to update such golden files automatically. For updating the golden files related to just that particular test, I ran

$ make test TEST_PKG_PATH="./cmd/flux" TEST_ARGS="-run TestCreateGitSecret -update"

The golden file got updated and I got the following diff:

diff --git a/cmd/flux/testdata/create_secret/git/git-bearer-token.yaml b/cmd/flux/testdata/create_secret/git/git-bearer-token.yaml
index 52a37a25..7dcfde2d 100644
--- a/cmd/flux/testdata/create_secret/git/git-bearer-token.yaml
+++ b/cmd/flux/testdata/create_secret/git/git-bearer-token.yaml
@@ -6,3 +6,4 @@ metadata:
   namespace: my-namespace
 stringData:
   bearerToken: ghp_baR2qnFF0O41WlucePL3udt2N9vVZS4R0hAS
+

And after that, running the test without the -update flag makes it pass.

I need further guidance on whether the data for bearerToken needs to be captured as .data.bearerToken or .stringData.bearerToken? The current implementation is for .stringData

The other secret related tests also use stringData, so it should be fine to use stringData for this.

[Santosh1176]

running the test without the -update flag makes it pass.

@darkowlzz Thank you for clarifying this for me, really helps.

I'll look into the error part.
Thank you.

[darkowlzz]

After addressing the above review comments, please rebase on the latest main branch, squash all the commits into one and mark this PR as ready. It looks almost ready to me.

[darkowlzz]

Overall, it looks good to me. Thanks for implementing it.
It'd be better to have one more reviewer go through it before we merge it.

[darkowlzz]

LGTM!

[Santosh1176]

Thank you for your guidance.