Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update components to v0.3.0 #474

Merged
merged 2 commits into from
Nov 20, 2020
Merged

Conversation

relu
Copy link
Member

@relu relu commented Nov 17, 2020

Updates to use metav1.Condition type and removes references for
deprecated corev1.Condition* constants and uses the new k8s api/meta
helpers in place of the old pkg/apis/meta types.

Depends on fluxcd/source-controller#195, fluxcd/notification-controller#83, fluxcd/kustomize-controller#174

@relu relu force-pushed the adopt-k8s-conditions branch 2 times, most recently from 975fa46 to 380ed15 Compare November 19, 2020 16:43
@relu relu marked this pull request as ready for review November 19, 2020 16:43
@relu relu marked this pull request as draft November 19, 2020 16:44
@relu relu force-pushed the adopt-k8s-conditions branch from 380ed15 to f9681c1 Compare November 19, 2020 17:52
Updates to use metav1.Condition type and removes references for
deprecated corev1.Condition* constants and uses the new k8s api/meta
helpers in place of the old pkg/apis/meta types.

Signed-off-by: Aurel Canciu <[email protected]>
@relu relu force-pushed the adopt-k8s-conditions branch from f9681c1 to 2a789ec Compare November 20, 2020 11:19
@relu relu marked this pull request as ready for review November 20, 2020 11:20
@relu
Copy link
Member Author

relu commented Nov 20, 2020

Needs adjustments to support fluxcd/kustomize-controller#180, @stefanprodan I assume you're probably already working on that 🔨.

@stefanprodan
Copy link
Member

@relu yes going to open a PR soon

@relu
Copy link
Member Author

relu commented Nov 20, 2020

Great, I'll rebase once you get it merged

Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @relu 🌻

@hiddeco hiddeco changed the title Refactor to adopt k8s standardized Condition type Update components to v0.3.0 Nov 20, 2020
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks @relu for driving this 🏅

@stefanprodan stefanprodan merged commit 9f47b55 into fluxcd:main Nov 20, 2020
@relu relu deleted the adopt-k8s-conditions branch November 20, 2020 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants