Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate arch flags in favor of multi-arch images #684

Merged
merged 1 commit into from
Jan 15, 2021
Merged

Conversation

hiddeco
Copy link
Member

@hiddeco hiddeco commented Jan 11, 2021

This commit deprecates the architecture flag (--arch) for the install
and bootstrap commands, in favor of the bundled multi-arch images that
will be available for the next MINOR range of GOTK controller releases.

Summary of changes:

  • *Arch variables have been marked as deprecated for both commands.
  • -arm64 suffix is no longer selectively added to the image definition
    of a component's Deployment.
  • kubernetes.io/arch node selector with the defined value has been
    removed from the components' Deployments.
  • Arch has been removed from the available Options in
    manifestgen/install.
  • Documentation references have been changed to highlight existence
    of multi-arch images and supported architectures.

Fixes: #493

@hiddeco hiddeco added enhancement New feature or request area/UX area/bootstrap Bootstrap related issues and pull requests area/install Install and uninstall related issues and pull requests hold Issues and pull requests put on hold labels Jan 11, 2021
@hiddeco hiddeco requested a review from stefanprodan January 11, 2021 20:53
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hiddeco hiddeco force-pushed the multi-arch-image branch 2 times, most recently from 2fb7ec2 to d95b668 Compare January 15, 2021 10:03
@hiddeco hiddeco removed the hold Issues and pull requests put on hold label Jan 15, 2021
@hiddeco hiddeco marked this pull request as ready for review January 15, 2021 10:03

Verified

This commit was signed with the committer’s verified signature. The key has been revoked.
eggplants haruna
This commit deprecates the architecture flag (`--arch`) for the install
and bootstrap commands, in favor of the bundled multi-arch images that
will be available for the next MINOR range of GOTK controller releases.

Summary of changes:

* `*Arch` variables have been marked as deprecated for both commands.
* `-arm64` suffix is no longer selectively added to the image definition
  of a component's `Deployment`.
* `kubernetes.io/arch` node selector with the defined value has been
  removed from the components' `Deployment`s.
* `Arch` has been removed from the available `Options` in
  `manifestgen/install`.
* Documentation references have been changed to highlight existence
  of multi-arch images and supported architectures.

Signed-off-by: Hidde Beydals <[email protected]>
@hiddeco hiddeco merged commit 9228130 into main Jan 15, 2021
@hiddeco hiddeco deleted the multi-arch-image branch January 15, 2021 10:40
@anthr76
Copy link

anthr76 commented Jan 15, 2021

Thank you!

ybelleguic pushed a commit to ybelleguic/flux2 that referenced this pull request Jan 9, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/bootstrap Bootstrap related issues and pull requests area/install Install and uninstall related issues and pull requests enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create architecture telemetry in the gotk
3 participants