refactor reconciler to use fluxcd/pkg/git #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aryan9600
force-pushed
the
use-pkg-git
branch
from
04b5b7e to
79faf2a
Compare
pjbgf
reviewed
Sep 2, 2022
Comment on lines
+275
to
270
| opts := git.CloneOptions{} | ||
| if ref != nil { | ||
| opts.Tag = ref.Tag | ||
| opts.SemVer = ref.SemVer | ||
| opts.Commit = ref.Commit | ||
| opts.Branch = ref.Branch | ||
| } |
There was a problem hiding this comment.
This could be a helper func, as we will need to convert ref to CloneOptions here and in tests.
aryan9600
force-pushed
the
use-pkg-git
branch
2 times, most recently
from
68c56c4 to
46b66ad
Compare
Signed-off-by: Sanskar Jaiswal <[email protected]>
aryan9600
force-pushed
the
use-pkg-git
branch
from
46b66ad to
7e63df9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor reconciler to use
fluxcd/pkg/gitandfluxcd/pkg/git/libgit2. Consequently, remove all git related helper methods and tests.Signed-off-by: Sanskar Jaiswal [email protected]