Upgrade controller-runtime to v0.7.0 #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
force-pushed
the
controller-runtime-v0.7.0
branch
from
f481b57 to
5a93c15
Compare
hiddeco
force-pushed
the
controller-runtime-v0.7.0
branch
10 times, most recently
from
66547cb to
734de9a
Compare
squaremo
approved these changes
Jan 14, 2021
| Namespace: obj.Meta.GetNamespace(), | ||
| }) | ||
| if err := r.List(ctx, &autoList, client.InNamespace(obj.GetNamespace()), | ||
| client.MatchingFields{repoRefKey: obj.GetName()}); err != nil { |
There was a problem hiding this comment.
The log message is removed here. I think it's ultimately OK (other GOTK controllers silently ignore errors in similar situations), I just want to flag it.
This commit upgrades the `controller-runtime` dependency to `v0.7.0`, including all changes required to make all wiring work again. - Upgrade `runtime` to v0.6.2 to include `controller-runtime` changes. - Logger has been removed from the reconciler, and is now retrieved from the `context.Context` passed to the `Reconcile` method and downwards functions. - Logger configuration flags are now bound to the flag set using `BindFlags` from `runtime/logger`, ensuring the same contract across GitOps Toolkit controllers, and the `--log-json` flag has been deprecated in favour of the `--log-encoding=json` default. - The `ChangePredicate` from `runtime` has changed to a `ReconcileRequestedPredicate`, and is now chained with the `GenerationChangedPredicate` from `controller-runtime` using `predicate.Or`. - Signatures that made use of `runtime.Object` have changed to `client.Object`, removing the requirement to e.g. call `runtime.Object#Object`. - The `leader-election-role` was changed, as leader election now works via the `coordination/v1` API. Other notable changes: - Upgrade of `image-reflector-controller` API package to include controller-runtime changes. - Upgrade of `source-controller` API package to v0.6.1. Signed-off-by: Hidde Beydals <[email protected]>
hiddeco
force-pushed
the
controller-runtime-v0.7.0
branch
from
734de9a to
0531dea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit upgrades the
controller-runtimedependency tov0.7.0,including all changes required to make all wiring work again.
runtimeto v0.6.2 to includecontroller-runtimechanges.from the
context.Contextpassed to theReconcilemethod anddownwards functions.
BindFlagsfromruntime/logger, ensuring the same contract acrossGitOps Toolkit controllers, and the
--log-jsonflag has beendeprecated in favour of the
--log-encoding=jsondefault.ChangePredicatefromruntimehas changed to aReconcileRequestedPredicate, and is now chained with theGenerationChangedPredicatefromcontroller-runtimeusingpredicate.Or.runtime.Objecthave changed toclient.Object, removing the requirement to e.g. callruntime.Object#Object.leader-election-rolewas changed, as leader election now worksvia the
coordination/v1API.Other notable changes:
image-reflector-controllerAPI package to includecontroller-runtime changes.
source-controllerAPI package to v0.6.1.Ref: fluxcd/flux2#613
Requires: fluxcd/image-reflector-controller#76