Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log HTTP errors to provide faster feedback #1028

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Log HTTP errors to provide faster feedback #1028

merged 1 commit into from
Dec 13, 2023

Conversation

hiddeco
Copy link
Member

@hiddeco hiddeco commented Dec 13, 2023

This configures a logger on the archive fetcher, to make HTTP errors surface faster when it fails to retrieve the artifact of a source.

Part of: fluxcd/flux2#4472

@hiddeco hiddeco added the area/ux In pursuit of a delightful user experience label Dec 13, 2023
This configures a logger on the archive fetcher, to make HTTP errors
surface faster when it fails to retrieve the artifact of a source.

Signed-off-by: Hidde Beydals <[email protected]>
@hiddeco hiddeco marked this pull request as ready for review December 13, 2023 10:54
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @hiddeco

@stefanprodan stefanprodan added the backport:release/v1.2.x To be backported to release/v1.2.x label Dec 13, 2023
@hiddeco hiddeco merged commit ddadd97 into main Dec 13, 2023
7 checks passed
@hiddeco hiddeco deleted the log-fetch-errors branch December 13, 2023 10:59
@fluxcdbot
Copy link
Member

Successfully created backport PR for release/v1.2.x:

stefanprodan pushed a commit that referenced this pull request Dec 13, 2023
Log HTTP errors to provide faster feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ux In pursuit of a delightful user experience backport:release/v1.2.x To be backported to release/v1.2.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants