Document behaviour of atomic fields with server-side apply #774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanprodan
reviewed
Dec 7, 2022
docs/spec/v1beta2/kustomization.md
Outdated
| @@ -279,7 +279,12 @@ kustomize.toolkit.fluxcd.io/ssa: merge | |||
| ``` | |||
|
|
|||
| **Note:** The fields defined in manifests will always be overridden, | |||
| the above procedure works only for adding new fields that don’t overlap with the desired state. | |||
| the above procedure works only for adding new fields that don’t overlap with the desired state | |||
There was a problem hiding this comment.
Suggested change
| the above procedure works only for adding new fields that don’t overlap with the desired state | |
| the above procedure works only for adding new fields that don’t overlap with the desired state. |
docs/spec/v1beta2/kustomization.md
Outdated
| For lists fields which are atomic (e.g `spec.tolerations` in PodSpec), Kubernetes doesn't allow different managers | ||
| for such fields, therefore any changes to these fields will be undone, even if you specify a manager. | ||
| For more context, please see the Kubernetes enhancement doc: | ||
| [555-server-side-apply](https://github.com/kubernetes/enhancements/blob/master/keps/sig-api-machinery/555-server-side-apply/README.md#lists) |
There was a problem hiding this comment.
Suggested change
| [555-server-side-apply](https://github.com/kubernetes/enhancements/blob/master/keps/sig-api-machinery/555-server-side-apply/README.md#lists) | |
| [555-server-side-apply](https://github.com/kubernetes/enhancements/blob/master/keps/sig-api-machinery/555-server-side-apply/README.md#lists). |
Signed-off-by: Somtochi Onyekwere <[email protected]>
stefanprodan
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #772
Signed-off-by: Somtochi Onyekwere [email protected]