Upgrade controller-runtime to v0.7.0 #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phillebaba
force-pushed
the
controller-runtime-update
branch
from
cc5a5a6 to
8ff0666
Compare
phillebaba
commented
Dec 20, 2020
phillebaba
force-pushed
the
controller-runtime-update
branch
from
8ff0666 to
0cabdac
Compare
hiddeco
force-pushed
the
controller-runtime-update
branch
2 times, most recently
from
e288fd9 to
5e14d77
Compare
hiddeco
force-pushed
the
controller-runtime-update
branch
from
5e14d77 to
9cbaac3
Compare
This commit upgrades the `controller-runtime` dependency to `v0.7.0`, including all changes required to make all wiring work again. - Upgrade `runtime` to v0.6.0 to include `controller-runtime` changes. - Loggers have been removed from the reconcilers and are now retrieved from the `context.Context` passed to the `Reconcile` method and downwards functions. - Logger configuration flags are now bound to the flag set using `BindFlags` from `runtime/logger`, ensuring the same contract across GitOps Toolkit controllers, and the `--log-json` flag has been deprecated in favour of the `--log-encoding=json` default. - The `ChangePredicate` from `runtime` has changed to a `ReconcilateAtChangedPredicate`, and is now chained with the `GenerationChangedPredicate` from `controller-runtime` using `predicate.Or`. - The `leader-election-role` was changed, as leader election now works via the `coordination/v1` API. Other notable changes: - Use `DeletionTimestamp` of resource object to determine readiness. - `source-controller` API dependency has been upgraded to `v0.6.0` which also uses `controller-runtime` `v0.7.0`. Co-authored-by: Hidde Beydals <[email protected]> Signed-off-by: Philip Laine <[email protected]> Signed-off-by: Hidde Beydals <[email protected]>
hiddeco
force-pushed
the
controller-runtime-update
branch
from
9cbaac3 to
ed9382e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: fluxcd/flux2#613
This PR upgrades the
controller-runtimedependency tov0.7.0,including all changes required to make all wiring work again.
runtimeto v0.6.0 to includecontroller-runtimechanges.from the
context.Contextpassed to theReconcilemethod anddownwards functions.
BindFlagsfromruntime/logger, ensuring the same contract acrossGitOps Toolkit controllers, and the
--log-jsonflag has beendeprecated in favour of the
--log-encoding=jsondefault.ChangePredicatefromruntimehas changed to aReconcilateAtChangedPredicate, and is now chained with theGenerationChangedPredicatefromcontroller-runtimeusingpredicate.Or.leader-election-rolewas changed, as leader election now worksvia the
coordination/v1API.Other notable changes:
DeletionTimestampof resource object to determine readiness.source-controllerAPI dependency has been upgraded tov0.6.0which also uses
controller-runtimev0.7.0.