Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make slack channel optional #208

Merged
merged 4 commits into from
Jun 7, 2021
Merged

Make slack channel optional #208

merged 4 commits into from
Jun 7, 2021

Conversation

somtochiama
Copy link
Member

@somtochiama somtochiama commented Jun 7, 2021 •
edited
Loading

Changes

  • Makes slack channel optional
  • Only redacts token from logs if it is present (to prevent distorting the error message)
  • Checks status code of HTTP request and returns an error if not successful

Fixes: #200

Signed-off-by: Somtochi Onyekwere [email protected]

@somtochiama
Adds other 200 status code
fd90d4e 
Signed-off-by: Somtochi Onyekwere <[email protected]>
@somtochiama
Better error message
fb66d68 
Signed-off-by: Somtochi Onyekwere <[email protected]>
@somtochiama
Make slack channel optional
c2d9b1e 
Signed-off-by: Somtochi Onyekwere <[email protected]>
@somtochiama somtochiama changed the title Return an error when request status code is not 200 Make slack channel optional Jun 7, 2021
stefanprodan
stefanprodan approved these changes Jun 7, 2021
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @somtochiama 🌷

@stefanprodan stefanprodan added the area/alerting Alerting related issues and PRs label Jun 7, 2021
@stefanprodan stefanprodan merged commit 6be34ac into fluxcd:main Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanprodan stefanprodan stefanprodan approved these changes

Assignees
No one assigned
Labels
area/alerting Alerting related issues and PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Slack provider for a private channel doesn't work
2 participants
@somtochiama @stefanprodan