Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use conditions helper in reconciler (kstatus compat) #282

Merged
merged 3 commits into from
Nov 22, 2021
Merged

Use conditions helper in reconciler (kstatus compat) #282

merged 3 commits into from
Nov 22, 2021

Conversation

somtochiama
Copy link
Member

@somtochiama somtochiama commented Nov 1, 2021 •
edited by stefanprodan
Loading

Ref: fluxcd/flux2#1601

Co-authored-by: Piaras Hoban [email protected]
Co-authored-by: Hidde Beydals [email protected]
Co-authored-by: souleb [email protected]
Signed-off-by: Somtochi Onyekwere [email protected]

@somtochiama @hiddeco @souleb
Use conditions helper in reconciler
19a0daa 
Co-authored-by: Piaras Hoban <[email protected]>
Co-authored-by: Hidde Beydals <[email protected]>
Co-authored-by: souleb <[email protected]>
Signed-off-by: Somtochi Onyekwere <[email protected]>
@hiddeco hiddeco self-assigned this Nov 5, 2021
hiddeco
hiddeco reviewed Nov 8, 2021
View reviewed changes
controllers/alert_controller.go Outdated Show resolved Hide resolved
controllers/alert_controller.go Outdated Show resolved Hide resolved
controllers/alert_controller.go Show resolved Hide resolved
controllers/alert_controller.go Outdated Show resolved Hide resolved
controllers/provider_controller.go Outdated Show resolved Hide resolved
controllers/provider_controller.go Outdated Show resolved Hide resolved
controllers/provider_controller.go Show resolved Hide resolved
controllers/receiver_controller.go Outdated Show resolved Hide resolved
controllers/receiver_controller.go Outdated Show resolved Hide resolved
hiddeco
hiddeco approved these changes Nov 18, 2021
View reviewed changes
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks all 🙇

It would be great if eventually the test suite can also be ported, as I think the current one is quite minimal.

@hiddeco hiddeco removed their assignment Nov 18, 2021
@stefanprodan stefanprodan added the enhancement New feature or request label Nov 18, 2021
@stefanprodan stefanprodan changed the title Use conditions helper in reconciler Use conditions helper in reconciler (kstatus compat) Nov 22, 2021
@stefanprodan stefanprodan merged commit 12c8c87 into main Nov 22, 2021
@stefanprodan stefanprodan deleted the reconcilers-dev branch November 22, 2021 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiddeco hiddeco hiddeco approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@somtochiama @hiddeco @stefanprodan