Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force github.com/emicklei/go-restful to v2.16.0 #390

Merged
merged 1 commit into from
Jul 12, 2022
Merged

Force github.com/emicklei/go-restful to v2.16.0 #390

merged 1 commit into from
Jul 12, 2022

Conversation

hiddeco
Copy link
Member

@hiddeco hiddeco commented Jul 12, 2022 •
edited
Loading

This addresses CVE-2022-1996, due to v2.16.0 including
emicklei/go-restful@9266625
and v3.8.0 including
emicklei/go-restful@fd3c327

Trivy still detects a false positive due to an outdated database.

usr/local/bin/notification-controller (gobinary)

Total: 1 (UNKNOWN: 0, LOW: 0, MEDIUM: 0, HIGH: 0, CRITICAL: 1)

┌────────────────────────────────┬───────────────┬──────────┬──────────────────────┬───────────────┬──────────────────────────────────────────────────────────────┐
│            Library             │ Vulnerability │ Severity │  Installed Version   │ Fixed Version │                            Title                             │
├────────────────────────────────┼───────────────┼──────────┼──────────────────────┼───────────────┼──────────────────────────────────────────────────────────────┤
│ github.com/emicklei/go-restful │ CVE-2022-1996 │ CRITICAL │ v2.16.0+incompatible │ v3.8.0        │ go-restful: Authorization Bypass Through User-Controlled Key │
│                                │               │          │                      │               │ https://avd.aquasec.com/nvd/cve-2022-1996                    │
└────────────────────────────────┴───────────────┴──────────┴──────────────────────┴───────────────┴──────────────────────────────────────────────────────────────┘

@hiddeco hiddeco added the area/ci CI related issues and pull requests label Jul 12, 2022
@hiddeco hiddeco requested a review from pjbgf July 12, 2022 11:48
@hiddeco
Fix github.com/emicklei/go-restful (CVE-2022-1996)
26bb2a3 
This addresses CVE-2022-1996, due to v2.16.0 including
emicklei/go-restful@9266625
and v3.8.0 including
emicklei/go-restful@fd3c327

Trivy still detects a false positive due to an outdated database.

Signed-off-by: Hidde Beydals <[email protected]>
@hiddeco hiddeco force-pushed the fix-cve-2022-1996 branch from 79c9eef to 26bb2a3 Compare July 12, 2022 11:56
pjbgf
pjbgf approved these changes Jul 12, 2022
View reviewed changes
Copy link
Member

@pjbgf pjbgf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thanks @hiddeco

@hiddeco hiddeco merged commit edadd9c into main Jul 12, 2022
@hiddeco hiddeco deleted the fix-cve-2022-1996 branch July 12, 2022 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjbgf pjbgf pjbgf approved these changes

Assignees
No one assigned
Labels
area/ci CI related issues and pull requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hiddeco @pjbgf