kustomize/filesys: config of allowed prefixes #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
added
enhancement
hiddeco
force-pushed
the
kus-fs-allow-prefix
branch
2 times, most recently
from
3e112d2 to
3abdbb3
Compare
hiddeco
changed the title
This introduction is required for the build of Kustomizations which refer to remote bases, as the internal load process creates new temporary directories to fetch these into. By ensuring the `root` of the FS does not start with an allowed prefix, it is not possible for a FS to reach into another FS if the program which creates them uses a static list. This solution is not optimal, and is a signal we need to fork Kustomize (and advocate upstream), to simply allow a more diverse configuration of loader restrictions. Making this FS implementation obsolete. Signed-off-by: Hidde Beydals <[email protected]>
hiddeco
force-pushed
the
kus-fs-allow-prefix
branch
from
3abdbb3 to
a2505ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduction is required for the build of Kustomizations which
refer to remote bases, as the internal load process creates new
temporary directories to fetch these into.
By ensuring the
rootof the FS does not start with an allowed prefix,it is not possible for a FS to reach into another FS if the program
which creates them uses a static list.
This solution is not optimal, and is a signal we need to fork Kustomize
(and advocate upstream), to simply allow a more diverse configuration
of loader restrictions. Making this FS implementation obsolete.