Upgrade controller-runtime to v0.7.0 #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hidde Beydals <[email protected]>
As predicates can be chained and used in conjunction with others, it is more useful to do just one thing in the predicate: detecting changes to the meta.ReconcileAtAnnotation. The generation changes can still be detected by chaining the predicate together with the predicate.GenerationChangedPredicate from controller-runtime itself using predicate.Or. Signed-off-by: Hidde Beydals <[email protected]>
hiddeco
force-pushed
the
runtime/controller-runtime-v0.7.0
branch
from
be66e5a to
1a63245
Compare
stefanprodan
requested changes
Dec 17, 2020
hiddeco
force-pushed
the
runtime/controller-runtime-v0.7.0
branch
5 times, most recently
from
d4a50f9 to
6c37f8d
Compare
hiddeco
force-pushed
the
runtime/controller-runtime-v0.7.0
branch
2 times, most recently
from
909c9b7 to
7fe639a
Compare
This commit refactors the `runtime/logger` package so that consumers can bind their flagset to the default flag configuration, making it easier for all consumers to follow the same contract. Signed-off-by: Hidde Beydals <[email protected]>
hiddeco
force-pushed
the
runtime/controller-runtime-v0.7.0
branch
from
7fe639a to
7bbb6fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: fluxcd/flux2#613
ChangePredicateto chain-ableReconcileAtChangedPredicateincludingevent.UpdateEventchangesruntime/loggerto re-use more ofsigs.k8s.io/controller-runtime/pkg/log/zap