http/fetch: allow configuring a logger on client #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
force-pushed
the
http-fetch-logger
branch
from
6019b0e to
ba2cf04
Compare
This allows for the configuration of a logger on the retryable HTTP client. While adding builtin support for providing a `logr.Logger` instance, which will be wrapped in a `retryablehttp.LeveledLogger` to only log errors. Signed-off-by: Hidde Beydals <[email protected]>
hiddeco
force-pushed
the
http-fetch-logger
branch
from
ba2cf04 to
f78f245
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for the configuration of a logger on the retryable HTTP client. While adding builtin support for providing a
logr.Loggerinstance, which will be wrapped in aretryablehttp.LeveledLoggerto only log errors.Part of: fluxcd/flux2#4472