Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crds: set default observedGeneration to -1 #517

Merged
merged 1 commit into from
Dec 9, 2021
Merged

crds: set default observedGeneration to -1 #517

merged 1 commit into from
Dec 9, 2021

Conversation

cwyl02
Copy link
Contributor

@cwyl02 cwyl02 commented Dec 8, 2021 •
edited by stefanprodan
Loading

Set default status.observedGeneration to -1 for the following CRDs

  • HelmRepository
  • HelmChart
  • GitRepository
  • Bucket

Fix: #516

Signed-off-by: York Chen [email protected]

@hiddeco hiddeco changed the title set default observedGeneration to -1 crds: set default observedGeneration to -1 Dec 9, 2021
@hiddeco hiddeco force-pushed the default-observed-generation branch from 0fa24c6 to 52d21ec Compare December 9, 2021 12:33
@hiddeco
crds: set default observedGeneration to -1
9eab99f 
This ensures the resources aren't marked as Healthy prematurely
by tools as e.g. kstatus. Which will now report a status of
`InProgress` instead of `Ready`.

Signed-off-by: York Chen <[email protected]>
@hiddeco hiddeco force-pushed the default-observed-generation branch from 52d21ec to 9eab99f Compare December 9, 2021 13:22
@hiddeco hiddeco marked this pull request as ready for review December 9, 2021 13:23
hiddeco
hiddeco approved these changes Dec 9, 2021
View reviewed changes
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to run make manifests to make the tests work, which might be helpful knowledge for next time :-). As I think you manually made changes, while part of our resources is generated from the Go code.

Thank you very much, and ☕ to your first contribution 💯

@hiddeco hiddeco merged commit ddad549 into fluxcd:main Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiddeco hiddeco hiddeco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set default observedGeneration to -1
2 participants
@cwyl02 @hiddeco