Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make logs less noisy #1000

Merged
merged 2 commits into from
Dec 5, 2022
Merged

Make logs less noisy #1000

merged 2 commits into from
Dec 5, 2022

Conversation

kwapik
Copy link
Contributor

@kwapik kwapik commented Dec 5, 2022

Description of change

  • Move all Info logs from Olric to Debug, as they are too noisy.
  • Make sampled logs appear once per 5 minutes instead of once per 5 seconds.
Checklist
  • Tested in playground or other setup

This change is Reviewable

@kwapik kwapik requested a review from a team as a code owner December 5, 2022 15:28
@kwapik kwapik requested a review from a team as a code owner December 5, 2022 15:30
@kwapik kwapik changed the title Silence Olric info logs Make logs less noisy Dec 5, 2022
@kwapik kwapik enabled auto-merge (squash) December 5, 2022 15:31
@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Base: 3.23% // Head: 42.83% // Increases project coverage by +39.59% 🎉

Coverage data is based on head (07b56db) compared to base (0c14270).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##            main    #1000       +/-   ##
==========================================
+ Coverage   3.23%   42.83%   +39.59%     
==========================================
  Files        296      296               
  Lines      21339    21339               
==========================================
+ Hits         691     9140     +8449     
+ Misses     20579    11640     -8939     
- Partials      69      559      +490     
Impacted Files Coverage Δ
pkg/distcache/logwriter.go 58.82% <33.33%> (ø)
pkg/log/samplers.go 87.09% <100.00%> (+70.96%) ⬆️
pkg/policies/controlplane/runtime/circuit.go 2.55% <0.00%> (+2.55%) ⬆️
...tuators/rate/ratetracker/lazy-sync-rate-tracker.go 85.29% <0.00%> (+2.94%) ⬆️
pkg/panichandler/panichandler.go 38.00% <0.00%> (+4.00%) ⬆️
...tuators/rate/ratetracker/distcache-rate-tracker.go 79.54% <0.00%> (+4.54%) ⬆️
pkg/info/info.go 64.40% <0.00%> (+6.77%) ⬆️
pkg/alertmanager/client/zz_generated.deepcopy.go 8.00% <0.00%> (+8.00%) ⬆️
.../actuators/rate/ratetracker/basic-limit-checker.go 80.55% <0.00%> (+8.33%) ⬆️
pkg/policies/controlplane/components/decider.go 9.48% <0.00%> (+9.48%) ⬆️
... and 190 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kwapik kwapik disabled auto-merge December 5, 2022 16:33
@kwapik kwapik merged commit 4c3a1ba into main Dec 5, 2022
@kwapik kwapik deleted the kwapik/silence_orlic_info_logs branch December 5, 2022 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants