-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move classifier to policies #211
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #211 +/- ##
==========================================
+ Coverage 46.29% 49.63% +3.33%
==========================================
Files 224 224
Lines 18627 18493 -134
==========================================
+ Hits 8624 9179 +555
+ Misses 9462 8740 -722
- Partials 541 574 +33
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
…hash label from flux_meter metric. Rationale: (1) User is explicitly aware of flux_meter metric, removing smart label substitution helps maintain WYSIWYG. (2) User refers to explicit metric in Prometheus and is aware of the implication of having older data in the database for older renditions of the Policy. In certain cases it might be useful to act on old data. E.g. to calculate setpoint on a large time range. If it is not desirable, the user may version the metric by putting the version explicity in the flux_meter_name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is