Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move classifier to policies #211

Merged
merged 14 commits into from
Aug 28, 2022
Merged

Move classifier to policies #211

merged 14 commits into from
Aug 28, 2022

Conversation

harjotgill
Copy link
Contributor

@harjotgill harjotgill commented Aug 27, 2022

This change is Reviewable

@codecov
Copy link

codecov bot commented Aug 27, 2022

Codecov Report

Merging #211 (03f650f) into main (0b87dd1) will increase coverage by 3.33%.
The diff coverage is 48.16%.

@@            Coverage Diff             @@
##             main     #211      +/-   ##
==========================================
+ Coverage   46.29%   49.63%   +3.33%     
==========================================
  Files         224      224              
  Lines       18627    18493     -134     
==========================================
+ Hits         8624     9179     +555     
+ Misses       9462     8740     -722     
- Partials      541      574      +33     
Impacted Files Coverage Δ
cmd/aperture-controller/controller.go 0.00% <0.00%> (ø)
cmd/aperture-controller/controller/provider.go 0.00% <0.00%> (ø)
pkg/flowcontrol/common/flowcontrol.go 100.00% <ø> (ø)
pkg/flowcontrol/common/metrics.go 74.07% <ø> (ø)
pkg/flowcontrol/envoy/authz.go 49.27% <ø> (ø)
pkg/flowcontrol/envoy/baggage/baggage.go 72.04% <ø> (ø)
pkg/flowcontrol/envoy/provide.go 46.15% <ø> (ø)
pkg/otelcollector/metricsprocessor/processor.go 72.76% <ø> (-0.38%) ⬇️
pkg/policies/controlplane/circuit-factory.go 74.67% <ø> (+74.67%) ⬆️
...g/policies/controlplane/component-stack-factory.go 67.30% <ø> (+61.53%) ⬆️
... and 80 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@harjotgill harjotgill marked this pull request as ready for review August 27, 2022 19:17
@harjotgill harjotgill requested a review from a team as a code owner August 27, 2022 19:17
tanveergill and others added 12 commits August 27, 2022 13:56
…hash label from flux_meter metric. Rationale: (1) User is explicitly aware of flux_meter metric, removing smart label substitution helps maintain WYSIWYG. (2) User refers to explicit metric in Prometheus and is aware of the implication of having older data in the database for older renditions of the Policy. In certain cases it might be useful to act on old data. E.g. to calculate setpoint on a large time range. If it is not desirable, the user may version the metric by putting the version explicity in the flux_meter_name
@harjotgill harjotgill merged commit 65128dd into main Aug 28, 2022
@harjotgill harjotgill deleted the classifier_refactor branch August 28, 2022 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants