Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rejected Tokens Panel With New Metric #2819

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

karansohi
Copy link
Contributor

@karansohi karansohi commented Oct 18, 2023

Description of change

Checklist
  • Tested in playground or other setup
  • Screenshot (Grafana) from playground added to PR for 15+ minute run
  • Documentation is changed or added
  • Tests and/or benchmarks are included
  • Breaking changes

Summary by CodeRabbit

  • Refactor: Improved the "Total Rejected Tokens" calculation in the Grafana dashboard. The update simplifies the calculation process and enhances the accuracy of the displayed data. This change will provide users with a more precise understanding of token rejections, aiding in system monitoring and decision-making processes.

@karansohi karansohi requested a review from a team as a code owner October 18, 2023 04:20
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 18, 2023

Walkthrough

The change simplifies and enhances the accuracy of the "Total Rejected Tokens" calculation in a Grafana stat panel. Instead of subtracting accepted tokens from incoming ones, it now directly sums up the rejected tokens.

Changes

File Summary
.../grafana/panels/total_rejected_tokens.libsonnet Modified the calculation of "Total Rejected Tokens" in a stat panel from subtracting accepted tokens from incoming ones to directly summing rejected tokens. This simplifies the calculation and improves accuracy.

🐇

In the realm of tokens and stats,

A rabbit hopped, avoiding spats.

Simplified the math, no more subtracts,

Now sums rejected, that's a fact! 🎉


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • Mention @coderabbitai in any review comment for bot assistance.
  • Note: Review comments are made on code diffs or files, not on the PR overview.

Pause Incremental Reviews

  • Insert @coderabbitai: ignore in the PR description to halt the bot's ongoing reviews. Remove the line to resume.
  • Additionally, enter @coderabbitai pause to halt the bot's ongoing reviews as any issue or review comment. To
    resume reviews, enter @coderabbitai resume as any issue or review comment.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Commits Files that changed from the base of the PR and between 09be732 and 6a824fa.
Files selected for processing (1)
  • blueprints/grafana/panels/total_rejected_tokens.libsonnet (1 hunks)
Additional comments (Suppressed): 1
blueprints/grafana/panels/total_rejected_tokens.libsonnet (1)
  • 7-12: The new calculation method for "Total Rejected Tokens" is more straightforward and accurate, as it directly sums up the number of rejected tokens. However, ensure that the rejected_tokens_total metric is correctly implemented and populated in the Prometheus metrics. Also, verify that this change doesn't affect other parts of the system that might be using the old calculation method.

@karansohi
Copy link
Contributor Author

Screenshot 2023-10-17 at 9 24 01 PM

@karansohi karansohi merged commit f980d10 into main Oct 18, 2023
5 checks passed
@karansohi karansohi deleted the update-rejected-tokens-panel branch October 18, 2023 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants